Opened on 11/09/2018 at 10:28:12 PM

Last modified on 10/08/2019 at 06:06:22 PM

#7117 reviewing change

Create test pages for first set of snippets

Reported by: Ross Assignee: Ross
Priority: P2 Milestone:
Module: Unknown Keywords:
Cc: kzar, mjethani, erikvold, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/10

Description (last modified by Ross)

Background

Developers have been adding examples to the snippets tickets for testing. These should be collected together and added to the ​testpages.

What to change

Create test pages from the examples given in the tickets. Also cover variations, such as using regex parameters. To avoid large code reviews this ticket should address these snippets:

#6809: hide-if-contains
#6969: abort-on-property-read
#7207: abort-on-property-write
#7141: abort-current-inline-script

Attachments (0)

Change History (9)

comment:1 Changed on 11/15/2018 at 04:25:51 AM by erikvold

  • Cc erikvold added

comment:2 Changed on 01/29/2019 at 10:58:30 AM by Ross

  • Description modified (diff)

comment:3 Changed on 01/29/2019 at 12:02:27 PM by kzar

  • Cc sebastian added
  • Component changed from Websites to Unknown
  • Ready set

comment:4 Changed on 01/29/2019 at 12:02:42 PM by kzar

  • Owner set to Ross

comment:5 Changed on 03/21/2019 at 02:36:48 PM by Ross

  • Description modified (diff)
  • Summary changed from Create test pages for snippets to Create test pages for first set of snippets

comment:6 Changed on 03/21/2019 at 02:41:13 PM by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 09/04/2019 at 09:06:09 AM by nps1337

spam

Last edited on 10/08/2019 at 06:06:16 PM by kzar

comment:8 Changed on 09/05/2019 at 07:44:19 AM by Elegantitservices

spam

Last edited on 10/08/2019 at 06:06:19 PM by kzar

comment:9 Changed on 09/11/2019 at 12:32:17 PM by nps1337

spam

Last edited on 10/08/2019 at 06:06:22 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as reviewing .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ross.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.