Opened on 06/26/2018 at 08:52:57 AM

Closed on 08/29/2019 at 05:43:52 PM

#6766 closed change (rejected)

Add "spies" in the test framework

Reported by: hfiguiere Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: mjethani, erikvold Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Issue #6437 include some testing that would benefit a lot from having "spies" to check if some code path is taken.

What to change

  • Pick a module for "spies" (TBD)
  • Change the tests for issue #6437 to use spies (see setTestMode())

Attachments (0)

Change History (4)

comment:1 Changed on 06/26/2018 at 07:05:38 PM by mjethani

  • Cc mjethani added

comment:2 Changed on 11/15/2018 at 05:28:44 AM by erikvold

  • Cc erikvold added

comment:3 Changed on 11/15/2018 at 05:29:30 AM by erikvold

I like ​https://www.npmjs.com/package/sinon for this, we used it in the flattr-extension ​https://github.com/flattr/flattr-extension

comment:4 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.