Opened on 06/26/2018 at 07:07:21 AM
Closed on 03/27/2019 at 07:19:31 PM
Last modified on 05/21/2019 at 11:18:21 AM
#6765 closed defect (rejected)
No COPYING file in the root directory
Reported by: | dr_boo | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Platform | Keywords: | |
Cc: | Kai, sebastian, greiner, mjethani | Blocked By: | |
Blocking: | #6936 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/110 |
Description (last modified by mapx)
GNU General Public License, version 3.0"
- "Add a COPYING file with a copy of the GNU GPL or GNU AGPL." -
https://www.gnu.org/licenses/gpl-howto.html
- The latest release (at this writing)
https://addons.mozilla.org/firefox/downloads/file/957947/adblock_plus-3.1-an+fx.xpi doesn't contain a copy of the GNU GPL 3.0 license in the root directory.
- Can you please download https://www.gnu.org/licenses/gpl-3.0.txt and save it as file name "COPYING", and
place the file in the root directory for Adblock Plus?
Attachments (0)
Change History (11)
comment:1 Changed on 06/26/2018 at 07:09:13 AM by dr_boo
comment:3 Changed on 06/27/2018 at 05:38:29 PM by greiner
- Cc Kai sebastian greiner added
- Component changed from Unknown to Platform
We do include a COPYING file in both hg.adblocklus.org/adblockplus as well as hg.adblockplus.org/adblockpluschrome. It seems that neither of those includes this file in the extension bundle though.
comment:4 Changed on 09/13/2018 at 03:29:05 PM by sebastian
As far as I understand (please correct me if I'm wrong Kai), there is no need to bundle a copy of the license with the build. It's generated code anyway, not the source code that is subject to the license, and the license is stated on the AMO page.
comment:5 Changed on 10/08/2018 at 11:54:31 AM by greiner
- Blocking 6936 added
- Review URL(s) modified (diff)
As part of this change we've added a COPYING file to adblockplusui in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/93fa6916fbb0faabbab5ba87b1c161eec941e92d.
Whether or not the file should be included in the extension build seems to be up to Kai to decide then.
comment:6 Changed on 03/27/2019 at 08:12:48 AM by mjethani
- Cc mjethani added
comment:7 Changed on 03/27/2019 at 03:27:18 PM by Kai
No need to bundle it with the extension build. Only with the source code. But if its not a big hassle to ad the COPYING file to the extension bundle, then you should do it anyway to increase transparency.
comment:8 Changed on 03/27/2019 at 07:19:31 PM by sebastian
- Resolution set to rejected
- Status changed from new to closed
comment:9 Changed on 05/20/2019 at 10:58:23 AM by abpbot
A commit referencing this issue has landed:
Issue 6765 - Added COPYING file
comment:10 Changed on 05/21/2019 at 10:26:03 AM by kzar
- Blocking 6936 removed
comment:11 Changed on 05/21/2019 at 11:18:21 AM by kzar
- Blocking 6936 added
I meant https://www.gnu.org/licenses/gpl-3.0.txt, not https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt