Opened on 07/12/2018 at 11:43:11 AM
Closed on 07/16/2018 at 05:55:11 PM
Last modified on 10/25/2018 at 10:30:11 AM
#6788 closed change (fixed)
Integrate stylelint-config-eyeo into adblockplusui
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/58 |
||
Description (last modified by greiner)
Background
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/79
What to change
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/79
Hints for testers
Styles should remain unchanged in all affected UI pages:
- Bubble UI
- Desktop options page
- First-run page
- Issue reporter
Attachments (0)
Change History (6)
comment:1 Changed on 07/12/2018 at 06:03:58 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 07/16/2018 at 05:55:11 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 08/28/2018 at 12:28:20 PM by greiner
- Blocking 6892 added
comment:4 Changed on 08/28/2018 at 04:38:59 PM by greiner
- Description modified (diff)
Added hints for testers.
comment:5 Changed on 09/13/2018 at 10:30:26 AM by abpbot
A commit referencing this issue has landed:
Issue 6788 - Integrated stylelint-config-eyeo
comment:6 Changed on 10/25/2018 at 10:30:11 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Styles still look fine.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
Done: https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/e2203ae57df54ba1c570620305e1d8131cbce317