Opened on 07/17/2018 at 11:52:40 AM
Closed on 10/25/2018 at 04:30:39 PM
Last modified on 10/26/2018 at 10:06:24 AM
#6795 closed defect (fixed)
Highlighter area coordinates offset by scrolling
| Reported by: | agiammarchi | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892, #7069 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/55 |
||
Description
As explained in GitLab:
https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/128
Attachments (0)
Change History (12)
comment:1 Changed on 08/01/2018 at 02:14:02 PM by greiner
- Owner set to agiammarchi
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 08/01/2018 at 02:14:20 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/01/2018 at 02:14:47 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 08/28/2018 at 12:29:12 PM by greiner
- Blocking 6892 added
comment:5 Changed on 10/22/2018 at 09:13:44 AM by Ross
This looks fixed except for in older versions: Chrome 49 and Opera 36.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
comment:6 Changed on 10/22/2018 at 09:26:21 AM by agiammarchi
Ross, could you be a bit more specific about what's broken in Chrome 49 ? AFAIK event.pageX/Y are in since Chrome 45, it'd be surprising if that never worked well 'till version 49.
Any detail on how you tested this would help, thanks.
comment:7 Changed on 10/22/2018 at 10:10:04 AM by agiammarchi
Ross, never mind, I've just managed to reproduce ... on it.
comment:8 Changed on 10/22/2018 at 10:34:19 AM by agiammarchi
This MR addresses the issue and fixes it hopefully once for all.
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/152
comment:9 Changed on 10/22/2018 at 10:35:16 AM by agiammarchi
- Resolution fixed deleted
- Status changed from closed to reopened
comment:10 Changed on 10/25/2018 at 04:26:37 PM by abpbot
A commit referencing this issue has landed:
Issue 6795 - Use event layerX/Y when browsers know these
comment:11 Changed on 10/25/2018 at 04:30:39 PM by greiner
- Blocking 7069 added
- Resolution set to fixed
- Status changed from reopened to closed
comment:12 Changed on 10/26/2018 at 10:06:24 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Done: https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/057a8be8ce590f99764d9dcbbe00e8ea335dee54