Opened on 07/30/2018 at 02:40:54 PM
Closed on 07/31/2018 at 12:58:31 PM
Last modified on 10/22/2018 at 03:19:29 PM
#6818 closed change (fixed)
Provide a way to make attribute values translatable in a declarative way
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/75 |
||
Description (last modified by greiner)
Background
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/114
What to change
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/114
Hints for testers
Translated texts should remain intact across all UIs.
Attachments (0)
Change History (6)
comment:1 Changed on 07/30/2018 at 02:49:40 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 07/31/2018 at 12:58:31 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 08/28/2018 at 12:30:40 PM by greiner
- Blocking 6892 added
comment:4 Changed on 08/28/2018 at 04:41:02 PM by greiner
- Description modified (diff)
Added hints for testers.
comment:5 Changed on 09/13/2018 at 10:30:28 AM by abpbot
A commit referencing this issue has landed:
Issue 6818 - Added ability to declaratively translate attribute values
comment:6 Changed on 10/22/2018 at 03:19:29 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Translated text still looks okay across UIs.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Firefox Mobile 62 / Android 7.1.1
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
Done: https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/573141463e28b024a2fb94a6a32d9416e934958d