Opened on 08/09/2018 at 10:40:20 AM
Closed on 09/06/2018 at 05:58:26 PM
Last modified on 10/08/2019 at 06:05:29 PM
#6846 closed change (fixed)
Add new error message for invalid snippet filters
| Reported by: | greiner | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | kzar, mjethani | Blocked By: | #6797 |
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/104 |
||
Description
Background
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/153
What to change
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/153
Attachments (0)
Change History (11)
comment:1 Changed on 09/04/2018 at 05:45:10 PM by saroyanm
comment:2 Changed on 09/04/2018 at 05:53:06 PM by greiner
- Blocking 6892 added
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 09/04/2018 at 06:20:41 PM by saroyanm
- Owner set to saroyanm
comment:4 Changed on 09/04/2018 at 06:20:50 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 follow-up: ↓ 6 Changed on 09/04/2018 at 06:31:12 PM by mjethani
I just saw diff, this needs to be "snippet filter" rather than "element hiding filter".
comment:6 in reply to: ↑ 5 Changed on 09/05/2018 at 10:32:02 AM by saroyanm
Replying to mjethani:
I just saw diff, this needs to be "snippet filter" rather than "element hiding filter".
Thanks Manish, updated.
comment:7 Changed on 09/06/2018 at 05:58:26 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 09/06/2018 at 07:35:13 PM by mjethani
This looks right, thanks!
comment:9 Changed on 09/13/2018 at 03:55:46 PM by abpbot
A commit referencing this issue has landed:
Issue 6846 - Added translations for invalid snippet filters error message
comment:10 Changed on 10/25/2018 at 09:40:26 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as described. Looks translated correctly.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
comment:11 Changed on 05/20/2019 at 09:44:49 AM by Arvind098
spam
We are referencing #6896 in the #6892, I assume this needs to be closed, or referenced instead.