Opened on 08/12/2018 at 09:47:59 AM
Closed on 08/29/2019 at 05:43:52 PM
#6858 closed defect (rejected)
User-defined comment filters always end up in a new SpecialSubscription object
| Reported by: | mjethani | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | kzar, jsonesen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mjethani)
Environment
Adblock Plus browser extension as of changeset a87d009836da
How to reproduce
- Do a fresh install of the web extension
- On the options page, add a new comment filter !foo and save the changes
- Add another comment filter !bar and save the changes
- Take a heap snapshot and examine the number of SpecialSubscription objects
Observed behaviour
There are two SpecialSubscription objects with one comment filter each.
Expected behaviour
There should be only one SpecialSubscription object and both filters should be in the same object.
Additional notes
This happens because SpecialSubscription.defaultsMap does not contain an entry for CommentFilter but the newly created SpecialSubscription object for the filter is still assigned a defaults value of ["blocking"], which causes FilterStorage.getGroupForFilter to return null for every new comment filter that is added.
Also see discussion in ##6859.
#7295 might also fix this.
Attachments (0)
Change History (10)
comment:1 Changed on 08/12/2018 at 09:50:40 AM by mjethani
- Cc jsonesen added
- Description modified (diff)
- Ready unset
comment:2 Changed on 09/02/2018 at 05:05:22 PM by jsonesen
- Owner set to jsonesen
comment:8 in reply to: ↑ 7 Changed on 10/09/2018 at 04:02:26 PM by mjethani
Replying to mjethani:
Jon, you added to review URL (hehe): "Are you still able to reproduce this? I am having trouble doing so on the current master bookmark of the abpchrome repo."
Let me check, but I'd be surprised if anything had changed.
If I follow the exact steps as given in the issue description, I am able to reproduce the issue exactly as described. This is with the current master branch of adblockpluschrome.
comment:10 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Jon, you added to review URL (hehe): "Are you still able to reproduce this? I am having trouble doing so on the current master bookmark of the abpchrome repo."
Let me check, but I'd be surprised if anything had changed.