Opened on 02/16/2019 at 02:15:55 PM

Closed on 02/21/2019 at 04:26:05 PM

Last modified on 10/08/2019 at 06:06:33 PM

#7295 closed change (fixed)

Add non-active filters to blocking group

Reported by:	mjethani	Assignee:	mjethani
Priority:	P3	Milestone:
Module:	Core	Keywords:
Cc:		Blocked By:
Blocking:		Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	yes
Review URL(s):	https://codereview.adblockplus.org/30009567/

Description (last modified by mjethani)

Background

While going through the code, I came across this line in lib/subscriptionClasses.js:

if (!(filter instanceof ActiveFilter) && type == "blacklist")

Clearly the intention here is that comments and invalid filters should go into the blocking group. It is written as "blacklist" in error. This explains #6858. Now we can fix this by replacing it with "blocking". Since the default group for a special subscription is blocking, this should fix #6858 and ensure that comments always end up in the subscription for blocking filters.

What to change

Replace "blacklist" with "blocking" in lib/subscriptionClasses.js. Update tests.

Hints for testers

Add a comment filter (e.g. !foo), reload the extension, and see that it is still there. Try the same with a blocking filter (e.g. foo) and element hiding filter (e.g. ##.foo).

Change History (6)

comment:1 Changed on 02/16/2019 at 02:24:37 PM by mjethani

Owner set to mjethani
Review URL(s) modified (diff)

comment:2 Changed on 02/16/2019 at 02:24:45 PM by mjethani

Status changed from new to reviewing

comment:3 Changed on 02/19/2019 at 02:11:16 AM by abpbot

A commit referencing this issue has landed:
Issue 7295 - Add non-active filters to blocking group

comment:4 Changed on 02/21/2019 at 04:26:05 PM by mjethani

Description modified (diff)
Resolution set to fixed
Status changed from reviewing to closed

comment:5 Changed on 07/19/2019 at 11:19:26 AM by ukacar

Verified working set

comment:6 Changed on 07/29/2019 at 07:39:59 AM by jha2125

spam

Last edited on 10/08/2019 at 06:06:33 PM by kzar

Summary:

Description:

You may use WikiFormatting here.

=== Background ===
While going through the code, I came across [https://hg.adblockplus.org/adblockpluscore/file/b86a01e2db02/lib/subscriptionClasses.js#l380 this line] in `lib/subscriptionClasses.js`:

{{{
if (!(filter instanceof ActiveFilter) && type == "blacklist")
}}}

Clearly the intention here is that comments and invalid filters should go into the blocking group. It is written as `"blacklist"` in error. This explains #6858. Now we can fix this by replacing it with `"blocking"`. Since the [https://hg.adblockplus.org/adblockpluscore/file/b86a01e2db02/lib/subscriptionClasses.js#l446 default group for a special subscription] is `blocking`, this should fix #6858 and ensure that comments always end up in the subscription for blocking filters.

=== What to change ===
Replace `"blacklist"` with `"blocking"` in `lib/subscriptionClasses.js`. Update tests.

=== Hints for testers ===
Add a comment filter (e.g. `!foo`), reload the extension, and see that it is still there. Try the same with a blocking filter (e.g. `foo`) and element hiding filter (e.g. `##.foo`).

Type:

Priority:

Milestone:

Module:

Keywords:

Cc:

Blocked By:

Blocking:

Platform:

Ready:

Confidential:

Tester:

Verified working:

Review URL(s):

Context Navigation

#7295 closed change (fixed)

Add non-active filters to blocking group

Description (last modified by mjethani)

Background

What to change

Hints for testers

Attachments (0)

Change History (6)

comment:1 Changed on 02/16/2019 at 02:24:37 PM by mjethani

comment:2 Changed on 02/16/2019 at 02:24:45 PM by mjethani

comment:3 Changed on 02/19/2019 at 02:11:16 AM by abpbot

comment:4 Changed on 02/21/2019 at 04:26:05 PM by mjethani

comment:5 Changed on 07/19/2019 at 11:19:26 AM by ukacar

comment:6 Changed on 07/29/2019 at 07:39:59 AM by jha2125

Add Comment

Modify Ticket

Changed by kzar

Download in other formats:

Summary:
Description:	You may use WikiFormatting here. === Background === While going through the code, I came across [https://hg.adblockplus.org/adblockpluscore/file/b86a01e2db02/lib/subscriptionClasses.js#l380 this line] in `lib/subscriptionClasses.js`: {{{ if (!(filter instanceof ActiveFilter) && type == "blacklist") }}} Clearly the intention here is that comments and invalid filters should go into the blocking group. It is written as `"blacklist"` in error. This explains #6858. Now we can fix this by replacing it with `"blocking"`. Since the [https://hg.adblockplus.org/adblockpluscore/file/b86a01e2db02/lib/subscriptionClasses.js#l446 default group for a special subscription] is `blocking`, this should fix #6858 and ensure that comments always end up in the subscription for blocking filters. === What to change === Replace `"blacklist"` with `"blocking"` in `lib/subscriptionClasses.js`. Update tests. === Hints for testers === Add a comment filter (e.g. `!foo`), reload the extension, and see that it is still there. Try the same with a blocking filter (e.g. `foo`) and element hiding filter (e.g. `##.foo`).
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/30009567/