Opened on 08/21/2018 at 04:28:22 PM
Closed on 08/24/2018 at 04:14:08 PM
Last modified on 10/24/2018 at 02:47:11 PM
#6876 closed change (fixed)
Update code to work with Filter.prototype.subscriptions as a Set object
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | wspee, mjethani, kzar | Blocked By: | |
| Blocking: | #6933 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/94 |
||
Description (last modified by greiner)
Background
Filter.prototype.subscriptions is now a Set object (see https://issues.adblockplus.org/ticket/6559#comment:27).
What to change
Modify any code that assumes the type of Filter.prototype.subscriptions to be Array, treat it as a Set object now.
See also ui#166
Hints for testers
Requests and filters should show up as expected in DevTools panel.
Attachments (0)
Change History (10)
comment:2 Changed on 08/21/2018 at 04:34:17 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P1
- Ready set
comment:3 Changed on 08/24/2018 at 02:51:36 PM by greiner
- Owner set to greiner
comment:4 Changed on 08/24/2018 at 03:07:26 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 08/24/2018 at 04:14:08 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 08/28/2018 at 12:32:31 PM by greiner
- Blocking 6892 added
comment:7 Changed on 08/28/2018 at 04:43:31 PM by greiner
- Description modified (diff)
Added hints for testers.
comment:8 Changed on 09/06/2018 at 11:17:33 AM by greiner
- Blocking 6933 added; 6892 removed
comment:9 Changed on 09/11/2018 at 01:13:45 PM by abpbot
A commit referencing this issue has landed:
Issue 6876 - Adapted code to work with Set implementation of Filter.prototype.subscriptions
comment:10 Changed on 10/24/2018 at 02:47:11 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Requests and filters appear in the devtools log as expected.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Done: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/c7099fc1fd4035fcba00a78ac180c1b1e40d35e0