Opened on 08/22/2018 at 06:55:21 PM
Closed on 08/24/2018 at 10:49:23 AM
Last modified on 12/18/2018 at 12:28:25 PM
#6879 closed change (fixed)
Update adblockplusui dependency to 476bd7fa39b6
| Reported by: | saroyanm | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian, wspee | Blocked By: | #6866 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Lately we have noticed that the Icons on newer Firefox Version are broken. See -> https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/165 and https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/90
It would be great to have this changes in the release of ABP 3.3 if possible.
What to change
Update the adblockplusui dependency to hg: 476bd7fa39b6 git: 4cf24d8
| Ticket | Summary | Component |
|---|---|---|
| #6866 | Icons on mobile options page are broken | User-Interface |
Hints for testers
Ensure that Delete and Checkmark Icons are accessible on the Firefox Mobile.
Attachments (0)
Change History (7)
comment:1 Changed on 08/22/2018 at 07:00:45 PM by saroyanm
- Cc kzar sebastian wspee added
- Component changed from Unknown to Platform
comment:3 Changed on 08/22/2018 at 07:40:18 PM by abpbot
A commit referencing this issue has landed:
Issue 6879 - Update adblockplusui dependency to 476bd7fa39b6
comment:4 Changed on 08/24/2018 at 10:49:23 AM by sebastian
- Milestone set to Adblock-Plus-3.3-for-Chrome-Opera-Firefox
- Priority changed from Unknown to P1
- Ready set
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed on 08/24/2018 at 11:09:42 AM by Ross
This looks fixed for me on the device below. Will check another device shortly.
ABP 3.2.0.2107
Firefox 61
Galaxy J5 / Android 7.1.1
comment:6 Changed on 08/27/2018 at 09:32:14 AM by rscott
- Verified working set
Fixed for me as well on 2107/FF61/Pixel/Android 9.0. Thanks for this!
comment:7 Changed on 12/18/2018 at 12:28:25 PM by greiner
- Blocked By 6866 added
@Sebastian and @Winsley agreed that it's possible to land this change for the ABP V3.3 release.
Thanks a lot for being flexible regarding this change, I missed this issue, as the icon was accessible on the old FF, even on FF59 the icons were accessible.
I'll prepare also the patch and move forward after this ticket is made ready.