Opened on 08/22/2018 at 02:37:34 PM
Closed on 08/28/2018 at 01:18:45 PM
Last modified on 10/26/2018 at 12:03:15 PM
#6878 closed change (fixed)
Implement IOFilterSearch
| Reported by: | agiammarchi | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/92 |
||
Description
A complementary component for https://issues.adblockplus.org/ticket/6875 able to dispatch filter:add or filter:show events and handle user interaction.
Specs: https://gitlab.com/eyeo/specs/spec/merge_requests/149
Attachments (0)
Change History (8)
comment:1 Changed on 08/28/2018 at 12:33:55 PM by greiner
- Blocking 6892 added
comment:2 Changed on 08/28/2018 at 01:17:34 PM by greiner
- Owner set to agiammarchi
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 08/28/2018 at 01:17:47 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/28/2018 at 01:18:45 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/13/2018 at 10:30:30 AM by abpbot
Some commits referencing this issue have landed:
comment:6 Changed on 10/25/2018 at 10:01:54 AM by Ross
I'm not sure if I'm able to test this yet? It looks like background work for a new custom filter list in a future release?
comment:7 Changed on 10/25/2018 at 10:14:01 AM by agiammarchi
Ross that's correct. This component is not used yet in the UI but, as other components that were flagged ready, it landed in the release.
The build process won't even include the CSS, nor the JS, so this component can be safely ignored for release 3.4.
comment:8 Changed on 10/26/2018 at 12:03:15 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Okay thanks. Verifying this as it doesn't look to have caused any issues or side effects.
ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Done: