Opened on 08/24/2018 at 07:02:51 PM
Closed on 08/24/2018 at 07:26:44 PM
Last modified on 10/03/2018 at 11:28:12 AM
#6881 closed change (fixed)
[adblockpluschrome] Update adblockpluscore dependency to 4a504a8ac939
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, hfiguiere, mjethani | Blocked By: | |
| Blocking: | #6717 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
In #6717, adblockpluschrome will require a file from adblockpluscore, which is not yet present in the current depedency.
Included changes in adblockpluscore
The list of changes imported by this is:
What to change
Update the adblockpluscore dependency to:
| mercurial | git |
| 4a504a8ac939 | e752ad4 |
Hints for testers
Please find potential tasks in the tickets for the included changes, otherwise nothing should change.
Attachments (0)
Change History (9)
comment:1 Changed on 08/24/2018 at 07:03:34 PM by tlucas
- Blocking 6717 removed
comment:2 Changed on 08/24/2018 at 07:04:22 PM by tlucas
- Blocking 6717 added
comment:3 Changed on 08/24/2018 at 07:19:32 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:4 Changed on 08/24/2018 at 07:20:35 PM by tlucas
- Owner set to tlucas
comment:5 Changed on 08/24/2018 at 07:20:45 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 08/24/2018 at 07:25:58 PM by abpbot
comment:7 Changed on 08/24/2018 at 07:26:44 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 08/27/2018 at 10:06:58 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:9 Changed on 10/03/2018 at 11:28:12 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Checked that snippets still work and browser tests run in Firefox.
ABP 3.3.2.2164
Chrome 69 / 49 / Windows 10
Firefox 62 / 51 / Windows 10
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6881 - Update adblockpluscore to 4a504a8ac939 / e752ad4