Opened on 08/25/2018 at 09:05:13 AM
Closed on 08/25/2018 at 10:03:49 AM
Last modified on 10/03/2018 at 11:29:46 AM
#6882 closed defect (fixed)
[npm test] Firefox zombies remain when qunit tests fail
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Debian 9
Firefox 57
adblockpluschrome @ d29f5ec / 44766c66877b
How to reproduce
- Mock one of the qunit-tests to fail, e.g. change line 14 in qunit/test/cssEscaping.js from
let mustMatch = opts.mustMatch !== false;
tolet mustMatch = opts.mustMatch !== true;
- Completely shutdown every Firefox-process that might be running on your machine
- Install the dependencies to run the tests: $ npm install
- Execute the tests: $ npm test
- Monitor existing Firefox processes with e.g. htop, with a filter set to firefox
Observed behaviour
The tests fail with Assertion Message: CSS escaping, the firefox process remains in memory.
Expected behaviour
The tests should fail with Assertion Message: CSS escaping, the firefox process should be completely shut down and vanish from memory, no processes should remain.
Attachments (0)
Change History (6)
comment:1 Changed on 08/25/2018 at 09:35:14 AM by tlucas
- Status changed from new to reviewing
comment:3 Changed on 08/25/2018 at 10:03:16 AM by abpbot
comment:4 Changed on 08/25/2018 at 10:03:49 AM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/27/2018 at 10:06:58 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:6 Changed on 10/03/2018 at 11:29:46 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Firefox instances are shutdown if tests fail.
adblockpluschrome / master / 2164:856217ee8673
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6882 - always shutdown the browser gracefully