Opened on 08/25/2018 at 02:48:30 PM
Closed on 08/31/2018 at 09:05:38 PM
Last modified on 10/24/2018 at 01:43:48 PM
#6883 closed change (fixed)
Remove Filter.toRegExp function
| Reported by: | mjethani | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | kzar, sergz, jsonesen, greiner, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
It's not clear exactly why Filter.toRegExp exists, especially since it is merely an alias for filterToRegExp in lib/common.js. This function is not being used anywhere outside of lib/filterClasses.js itself.
What to change
Remove Filter.toRegExp and use filterToRegExp directly.
Hints for testers
This is a minor change already covered by unit tests.
Attachments (0)
Change History (9)
comment:1 Changed on 08/25/2018 at 02:49:21 PM by mjethani
- Cc jsonesen greiner added
comment:2 Changed on 08/25/2018 at 02:50:36 PM by mjethani
- Cc sebastian added
comment:3 Changed on 08/25/2018 at 02:50:59 PM by mjethani
comment:4 Changed on 08/27/2018 at 04:02:28 PM by jsonesen
- Owner set to jsonesen
comment:5 Changed on 08/27/2018 at 04:31:36 PM by greiner
No objections from me.
comment:6 Changed on 08/30/2018 at 06:15:29 PM by abpbot
A commit referencing this issue has landed:
Issue 6883 - Use filterToRegExp in lib/filterClasses.js
comment:7 Changed on 08/31/2018 at 09:02:53 PM by mjethani
- Ready set
comment:8 Changed on 08/31/2018 at 09:05:38 PM by mjethani
- Description modified (diff)
- Resolution set to fixed
- Status changed from new to closed
comment:9 Changed on 10/24/2018 at 01:43:48 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Unit tests pass and does not look to have caused any regressions.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
If no one has any objections, I'd like to remove this function.