Opened on 08/26/2018 at 05:55:28 PM

Closed on 08/29/2018 at 05:36:58 PM

#6885 closed change (fixed)

Indicate the expected outcome of the test pages though CSS

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Unknown Keywords:
Cc: Ross, tlucas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29865555

Description

Background

In order to automatically test against our test pages, we need a way to indicate the expected outcome in a machine-readable form. Currently, it's only human-readable instructions.

What to change

When the CSS class expected is added to any element up the tree, and no filter is active, every test page should be rendered like it is expected to be rendered with the given filters active.

Attachments (0)

Change History (3)

comment:1 Changed on 08/26/2018 at 05:57:04 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 08/29/2018 at 05:23:07 PM by abpbot

A commit referencing this issue has landed:
​Issue 6885 - Indicate the expected outcome of the test pages though CSS

comment:3 Changed on 08/29/2018 at 05:36:58 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.