Opened on 08/27/2018 at 05:53:55 AM
Closed on 08/27/2018 at 02:08:37 PM
Last modified on 10/18/2018 at 12:15:11 PM
#6886 closed change (fixed)
Add support for looking up SnippetFilter objects for a domain
| Reported by: | mjethani | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | hfiguiere, kzar | Blocked By: | |
| Blocking: | #6538, #6843 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by hfiguiere)
Background
The Snippets.getScriptsForDomain function returns the snippet scripts matching a given domain, which is enough for injecting code into a document but does not come with enough information for logging purposes (e.g. the entire filter text). There should be a Snippets.getFiltersForDomain that returns SnippetFilter objects instead.
What to change
Rename Snippets.getScriptsForDomain to Snippets.getFiltersForDomain and make it return SnippetFilter objects instead.
Update the tests accordingly.
Integration notes
This would require a change in adblockpluschrome, which is being done as part of #6843 anyway.
Hints for testers
Check that snippets filters still work. In the grand scheme of things verification of issue #6843 will probably include this.
Attachments (0)
Change History (7)
comment:1 Changed on 08/27/2018 at 05:54:53 AM by mjethani
- Owner set to hfiguiere
comment:2 Changed on 08/27/2018 at 05:55:14 AM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/27/2018 at 11:50:36 AM by hfiguiere
- Blocking 6843 added
comment:4 Changed on 08/27/2018 at 02:07:56 PM by abpbot
comment:5 Changed on 08/27/2018 at 02:08:37 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 10/18/2018 at 12:15:11 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Snippets still work and are logged to the devtools.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
A commit referencing this issue has landed:
Issue 6886 - Return snippet filters instead of just scripts