Opened on 08/28/2018 at 02:50:35 PM

Closed on 08/28/2018 at 03:51:39 PM

#6897 closed change (duplicate)

Remove the no-op implementation of Utils.generateChecksum()

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: Blocked By: #6889
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29867603/

Description

Background

Since issue #6889 bring adblockpluscore changes that include issue #6849, we no longer do checksums on filter lists. So we should remove the already no-op Utils.generateChecksum()

What to change

  • remove generateChecksum() from lib/utils.js

Hint for testers

  • nothing specific.

Attachments (0)

Change History (4)

comment:1 Changed on 08/28/2018 at 02:51:01 PM by hfiguiere

  • Blocked By 6889 added

comment:2 Changed on 08/28/2018 at 03:00:59 PM by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed on 08/28/2018 at 03:04:44 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/28/2018 at 03:51:39 PM by sebastian

  • Resolution set to duplicate
  • Status changed from reviewing to closed

This can be done during the dependency update in #6889.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.