Opened on 08/28/2018 at 03:04:32 PM
Closed on 09/05/2018 at 05:51:35 PM
Last modified on 12/17/2018 at 05:12:53 PM
#6898 closed change (fixed)
Duplicate "add" string
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/102 |
||
Description (last modified by saroyanm)
Background
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/175
What to change
Move "add" string translations from the composer.json into common.json and remove "add" source string from the composer.json
Attachments (0)
Change History (12)
comment:3 Changed on 09/04/2018 at 05:19:01 PM by saroyanm
- Owner set to saroyanm
comment:4 Changed on 09/04/2018 at 05:20:48 PM by saroyanm
- Status changed from new to reviewing
comment:6 Changed on 09/04/2018 at 06:22:25 PM by saroyanm
- Blocking 6892 removed
comment:7 Changed on 09/04/2018 at 06:23:57 PM by saroyanm
- Blocking 6892 added
comment:8 Changed on 09/05/2018 at 05:51:35 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 09/13/2018 at 10:30:32 AM by abpbot
comment:10 Changed on 09/13/2018 at 03:55:46 PM by abpbot
A commit referencing this issue has landed:
Issue 6898 - Removed translations for 'add' strings from composer.json
comment:11 Changed on 10/25/2018 at 10:03:10 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Looks done. Doesn't look to have caused any problems or missing strings.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
comment:12 Changed on 12/17/2018 at 05:12:53 PM by greiner
- Review URL(s) modified (diff)
A commit referencing this issue has landed:
Issue 6898 - Moved duplicate 'add' string into the common.json