Opened on 09/01/2018 at 01:03:12 PM
Closed on 08/29/2019 at 05:43:18 PM
Last modified on 10/01/2019 at 12:27:30 PM
#6917 closed defect (rejected)
Iframe collapsing doesn't work on Firefox
| Reported by: | mjethani | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | tschuster, sebastian | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
adblockpluschrome next branch as of changeset 0954083e568e
Firefox 61
How to reproduce
- Follow the instructions at https://testpages.adblockplus.org/en/filters/subdocument
Observed behaviour
The request for the iframe appears to be blocked (verify in DevTools panel), but the iframe itself remains visible.
Expected behaviour
The iframe should be "collapsed" (hidden) after the request is blocked.
Additional notes
It seems the content script is not getting the error event from the iframe; oddly it gets an error event from the link element (style sheet), even though the style sheet is loaded correctly.
This issue occurs on Firefox only.
Attachments (0)
Change History (4)
comment:1 Changed on 09/01/2018 at 04:13:14 PM by sebastian
- Cc tschuster sebastian added
comment:2 Changed on 09/03/2018 at 02:40:36 PM by sebastian
Thanks for filing a Firefox bug, Tom!
comment:3 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Frames don't get an error event on Chrome either, but we account for that by handling the load event as well specifically for frames. However, it seems on Firefox, if a frame is blocked, neither a load nor an error event is triggered. That is quite certainly a bug in Firefox.
I don't see any error event for the stylesheet.