Opened on 09/02/2018 at 01:40:10 AM
Closed on 09/04/2018 at 03:48:20 PM
Last modified on 10/24/2018 at 08:12:04 AM
#6918 closed change (fixed)
Automate the test pages
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Automation | Keywords: | |
| Cc: | tlucas, Ross, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Our test pages can currently only be tested manually which takes a lot of time. If we can automate those tests (and later have them even run by our CI), we have a higher chance to catch regressions early.
What to change
Add a new script to test/wrappers/ in adblockpluschrome, automating the following procedure using Selenium WebDriver (for Chrome and Firefox):
- Load testpages.adblockplus.org.
- Load any sub-pages linked there.
- On the sub-pages add the CSS class expected to the <body> element (this will render the page as it is expected to look with the given filters in effect).
- Take screenshots of the expected outcome.
- For each test case, add the respective filters to Adblock Plus, disable/remove any other filters, reload the page and compare it to the previously taken screenshot.
Out of scope
There are some test cases that cannot be covered by comparing screenshots, but require more complex interactions (e.g. the circumvention test cases and the popup tests). These are out of scope for now.
Attachments (0)
Change History (4)
comment:1 Changed on 09/02/2018 at 01:41:59 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/04/2018 at 03:46:22 PM by abpbot
comment:3 Changed on 09/04/2018 at 03:48:20 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 10/24/2018 at 08:12:04 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Automated tests run successfully in Firefox as well as Chromium.
adblockpluschrome / master / 2175:02d136073262
A commit referencing this issue has landed:
Issue 6918 - Integrated the test pages with the WebDriver-based test runner