Opened on 09/04/2018 at 10:10:53 AM

Closed on 08/30/2019 at 04:30:22 PM

#6924 closed change (rejected)

Relax selector-type-no-unknown rule

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Automation Keywords: closed-in-favor-of-gitlab
Cc: ire Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

stylelint-config-eyeo doesn't include the rule "selector-type-no-unknown" which means that we fall back to stylelint-config-recommended which has it set to true.

However, that means that we can't use custom elements in adblockplusui. Therefore we should relax this rule to allow for custom elements.

What to change

Add the following rule to stylelint-config-eyeo:

"selector-type-no-unknown": [true, {"ignore": "custom-elements"}]

Attachments (0)

Change History (1)

comment:1 Changed on 08/30/2019 at 04:30:22 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.