Opened on 09/04/2018 at 12:08:43 PM
Closed on 08/30/2019 at 04:30:22 PM
#6925 closed change (rejected)
Remove selector-no-qualifying-type stylelint rule
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Automation | Keywords: | closed-in-favor-of-gitlab |
| Cc: | ire, juliandoucette, agiammarchi, saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
stylelint-config-eyeo includes the rule
"selector-no-qualifying-type": [true, {"ignore": ["attribute"]}]
However, this rule causes various issues throughout adblockplusui and likely also other eyeo repositories which is why it may not be appropriate for inclusion in stylelint-config-eyeo.
Also note that we did discuss adapting our code to this rule but had to settle on not doing so since it would require further changes beyond those and may introduce regressions (see discussion).
What to change
Remove "selector-no-qualifying-type" rule from stylelint-config-eyeo.
Attachments (0)
Change History (1)
comment:1 Changed on 08/30/2019 at 04:30:22 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.