Opened on 09/07/2018 at 12:43:06 PM
Closed on 09/18/2018 at 12:47:42 PM
Last modified on 10/25/2018 at 10:28:42 AM
#6935 closed defect (fixed)
IOBigToggle not rendered
| Reported by: | agiammarchi | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/107 |
||
Description
To simplify IOElement lifecycle I've made some change to the HyperHTMLElement library that did not consider that IOSteps need to invoke created() N times and also inheritance might compromise initialization of each component.
Since, after investigation, I've discovered there was no issuw with older Firefox, I've updated the library to render automatically on creation if no created method is available (already tested too).
Attachments (0)
Change History (8)
comment:1 Changed on 09/07/2018 at 12:54:09 PM by agiammarchi
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed on 09/07/2018 at 12:56:07 PM by greiner
- Blocking 6892 added
- Priority changed from Unknown to P1
- Ready set
- Review URL(s) modified (diff)
comment:3 Changed on 09/13/2018 at 10:30:35 AM by abpbot
comment:4 Changed on 09/18/2018 at 12:24:31 PM by agiammarchi
- Resolution fixed deleted
- Status changed from closed to reopened
comment:5 Changed on 09/18/2018 at 12:24:49 PM by agiammarchi
Turns out, the version I've updated wasn't good enough to fix the issue in every browser.
comment:6 Changed on 09/18/2018 at 12:34:19 PM by agiammarchi
I'll close this as soon as I can double check the big toggle is visible in all our target browsers.
comment:7 Changed on 09/18/2018 at 12:47:42 PM by agiammarchi
- Resolution set to fixed
- Status changed from reopened to closed
comment:8 Changed on 10/25/2018 at 10:28:42 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. The big toggle is working as expected in all our target browsers.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
A commit referencing this issue has landed:
Issue 6935 - Update HyperHTMLELement to render IOBigToggle too