Opened on 09/12/2018 at 07:09:11 PM
Closed on 09/13/2018 at 03:36:51 PM
#6946 closed change (fixed)
Use linux for CI-tests in libadblockplus from appveyor
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/14 |
||
Description
Background
Travis-ci is based on a pretty old linux and in order to run tests we have to build V8 binaries for linux on such old linux machine. It's a certain burden for us, however appveyor has linux ubuntu 16.04 (xenial), so I would propose to use appveyor to build and run tests on linux, because in this case one is not limited by a particular version of ubuntu and can prepare v8 binaries even on ubuntu 18.04.
Long term story:
Despite there are plans regarding gitlab-ci based on our own runners, it's a good feature to support free publicly available CI services, so so far IMO we should keep them even after establishing a gitlab ci.
What to change
Change the config files for the corresponding services.
Attachments (0)
Change History (4)
comment:2 Changed on 09/13/2018 at 12:31:48 PM by hfiguiere
comment:3 Changed on 09/13/2018 at 12:55:22 PM by sergz
We could also use a docker image as a base to build on TravisCI.
I like the idea and I think we should include it, it was just easier to do it without docker in this particular case.
comment:4 Changed on 09/13/2018 at 03:36:51 PM by sergz
- Resolution set to fixed
- Status changed from new to closed
We could also use a docker image as a base to build on TravisCI.