Opened on 09/13/2018 at 03:54:50 PM
Closed on 09/16/2018 at 12:47:26 PM
#6950 closed change (fixed)
[python-abp] Don't include headers and metadata from includes into output
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas | Blocked By: | |
Blocking: | #6877 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by sebastian)
Background
Since #6920 we only consider metadata at the top of the filter list. However, python-abp parses each input file separately. So metadata given at the top of an included file would be considered, while Adblock Plus won't consider those metadata if they are not at the top of the resulting filter list.
This is mostly relevant when bundling pre-generated filter lists with. However, in that case we would want to provide explicit metadata for the bundled list. So it seems most appropriate (and also simplest) to strip any metadata and headers given in included files.
However, since we still allow comments (and consider metadata with malformed keys like Last modified as comments), we might want to change these semantics as well.
What to change
- Strip headers and metadatas from included files.
- Consider any comment whose text has a colon as metadata.
- Stop removing duplicate headers and metadata (this is no longer necessary since we don't include headers and metadata from included files anymore).
Attachments (0)
Change History (4)
comment:1 Changed on 09/13/2018 at 03:58:37 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/16/2018 at 12:42:24 PM by abpbot
comment:4 Changed on 09/16/2018 at 12:47:26 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 6950 - Don't include headers and metadata from includes into output