Opened on 09/13/2018 at 03:44:12 PM
Closed on 09/17/2018 at 12:47:52 PM
Last modified on 10/24/2018 at 01:16:46 PM
#6949 closed change (fixed)
Update adblockpluscore to c99ba575161f
| Reported by: | hfiguiere | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | #6923, #6944 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Update adblockpluscore dependency to get EasyList Portuguese into the default subscriptions, and to get the second part of the changes to the logic parsing the metadata from filter lists in.
What to change
Change dependencies for adblockplusore to c99ba575161f
This bring the following changes:
- Issue #6944 - Added EasyList Portuguese
- Issue #6923 (2nd part) - Simplify/Unify parsing of metadata in filter lists
Hint for testers
- Verify that EasyList Portuguese is in the default lists when you add a language.
- See ticket:6923#Hintsfortesters
Attachments (0)
Change History (9)
comment:1 Changed on 09/13/2018 at 03:48:54 PM by hfiguiere
- Description modified (diff)
- Owner set to hfiguiere
comment:2 Changed on 09/13/2018 at 03:51:23 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/13/2018 at 04:13:52 PM by sebastian
comment:4 Changed on 09/13/2018 at 04:50:35 PM by hfiguiere
Fair enough. As long as we get it in.
comment:5 Changed on 09/15/2018 at 04:19:45 PM by sebastian
- Blocked By 6923, 6944 added
- Description modified (diff)
- Priority changed from Unknown to P2
- Summary changed from Update adblockpluscore to hg:a735ad4e34e5 to Update adblockpluscore to ????
comment:6 Changed on 09/16/2018 at 12:43:50 PM by sebastian
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Ready set
- Summary changed from Update adblockpluscore to ???? to Update adblockpluscore to c99ba575161f
comment:7 Changed on 09/17/2018 at 12:26:33 PM by abpbot
A commit referencing this issue has landed:
Issue 6949 - Update adblockpluscore to hg:c99ba575161f git:ee3158d
comment:8 Changed on 09/17/2018 at 12:47:52 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 10/24/2018 at 01:16:46 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as described.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
If possible, I'd like to get this patch in there as well. (So that we don't have to test this functionality twice.)