Opened on 09/27/2018 at 05:13:44 PM
Closed on 09/28/2018 at 03:59:05 PM
#6997 closed change (fixed)
Use createStyleSheet implementation from core
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-3.5-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29893555/ |
||
Description (last modified by mjethani)
Background
The implementation of style sheet generation is now in core (#6956).
To use it, the adblockpluscore dependency should be updated. It would include the following changes over the last dependency update:
- #6937 - Lowercase RegExpFilter domains on demand
- #6956 - Move extension's style sheet generation into core
- #6972 - Use Buffer.from in tests
- #6822 - Report browser test errors
- #6987 - Fix regression preventing running individual tests
- #6983 - Implement prevent-inline-scripts snippet
- #6938 - Port hide-if-contains-and-matches-style snippet to Firefox
- #6989 - Optimize CSS rule generation
What to change
Update adblockpluscore dependency to hg:e9340eecc239 git:afbf0ac
Import the createStyleSheet function from adblockpluscore/lib/elemHide.js and use it instead of the current implementation in lib/contentFiltering.js.
Hints for testers
See individual issues above.
For the one non-dependency update change here, make sure that element hiding is working properly.
Attachments (0)
Change History (9)
comment:1 Changed on 09/27/2018 at 05:14:30 PM by mjethani
- Status changed from new to reviewing
comment:3 Changed on 09/27/2018 at 09:25:01 PM by abpbot
comment:5 Changed on 09/27/2018 at 10:06:12 PM by mjethani
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 09/28/2018 at 12:33:23 PM by mjethani
- Resolution fixed deleted
- Review URL(s) modified (diff)
- Status changed from closed to reopened
comment:7 Changed on 09/28/2018 at 12:33:34 PM by mjethani
- Status changed from reopened to reviewing
comment:8 Changed on 09/28/2018 at 03:58:38 PM by abpbot
A commit referencing this issue has landed:
Issue 6997 - Remove unused selectorGroupSize constant
comment:9 Changed on 09/28/2018 at 03:59:05 PM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 6997 - Use createStyleSheet implementation from core