Opened on 09/29/2018 at 12:38:40 AM
Closed on 09/29/2018 at 12:50:25 AM
Last modified on 10/17/2018 at 12:48:12 PM
#7002 closed change (fixed)
Update adblockpluscore dependency to hg:686f179cd357
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | #7001 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
There was a serious bug in core (#7001). It has been fixed, now we should update the dependency to hg:686f179cd357 git:d0f82ce. This update also includes a port of the hide-if-contains-and-matches-style snippet to Firefox (#6938).
What to change
Update adblockpluscore dependency to hg:686f179cd357 git:d0f82ce
Hints for testers
Attachments (0)
Change History (8)
comment:1 Changed on 09/29/2018 at 12:40:23 AM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/29/2018 at 12:40:54 AM by mjethani
- Cc sebastian added
comment:4 Changed on 09/29/2018 at 12:43:23 AM by sebastian
- Priority changed from Unknown to P1
- Ready set
comment:5 Changed on 09/29/2018 at 12:46:06 AM by mjethani
- Blocked By 7001 added
comment:6 Changed on 09/29/2018 at 12:49:40 AM by abpbot
comment:7 Changed on 09/29/2018 at 12:50:25 AM by mjethani
- Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/17/2018 at 12:48:12 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Memory usage issue looks fixed and the hide-if-contains-and-matches-style snippet now works on Firefox.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7002 - Update adblockpluscore dependency to hg:686f179cd357