Opened on 10/01/2018 at 01:43:51 PM
Closed on 10/08/2018 at 02:30:02 PM
#7004 closed defect (fixed)
build numbers differ between Mercurial / Git
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | #6682 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29903558/ |
||
Description (last modified by tlucas)
How to reproduce
- Clone adblockpluschrome from both www.github.com and hg.adblockplus.org (with git / hg accordingly)
- make sure to checkout / update both repositories to the current master
- Initiate a build of the current master $python build.py build -t gecko
- Look at the filename of the generated files
Observed behaviour
The build numbers (4th part of the version) differ (the build generated inside the git repository is lower)
Expected behaviour
The build numbers should match OR the build numbers generated from git should be higher (to avoid rejection of lower versions, once we start building / distributing from a git environment).
Hint
The responsible code is here
Git is not capable (to our current knowledge) of reliably reproducing the revision number yielded by Mercurial.
Attachments (0)
Change History (10)
comment:2 Changed on 10/06/2018 at 09:29:46 AM by tlucas
- Description modified (diff)
- Owner set to tlucas
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 10/06/2018 at 09:30:08 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 10/06/2018 at 09:33:57 AM by tlucas
- Blocking 6682 added
comment:5 Changed on 10/06/2018 at 10:59:00 AM by abpbot
A commit referencing this issue has landed:
Issue 7004 - Switch to a more robust buildnum generation
comment:6 Changed on 10/06/2018 at 10:59:37 AM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 10/08/2018 at 01:20:12 PM by tlucas
- Resolution fixed deleted
- Status changed from closed to reopened
comment:9 Changed on 10/08/2018 at 02:29:44 PM by abpbot
A commit referencing this issue has landed:
Issue 7004 - Actually return git's result
comment:10 Changed on 10/08/2018 at 02:30:02 PM by tlucas
- Resolution set to fixed
- Status changed from reopened to closed
From IRC: