Opened on 10/02/2018 at 05:49:56 PM
Closed on 10/05/2018 at 12:15:26 PM
Last modified on 10/24/2018 at 09:15:54 AM
#7014 closed change (fixed)
Update adblockplusui dependency to hg:42849c775697 (release-2018-4.3)
| Reported by: | saroyanm | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | wspee, sebastian, kzar, agiammarchi, greiner | Blocked By: | #7013, #7017, #7018 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by saroyanm)
Background
There were some regressions noticed, some of them are crutial(ex.: Issue reporter being broken on Firefox) that we would like to have in the ABP 3.4 release if possible:
| Ticket | Status | Resolution | Summary | Component | Owner |
|---|---|---|---|---|---|
| #7013 | closed | fixed | Firefox error: this.created() is not defined | User-Interface | |
| #7017 | closed | fixed | Firefox popup not closing on tabs update | User-Interface | |
| #7018 | closed | fixed | NoIssue - Beautify XML Report in Firefox too | User-Interface |
Also: Some FRP translations were gone after updating the source strings.
What to change
Change adblockplusui dependency to hg:42849c775697 git:1106767
Hints for testers
Most of the issue are fixed for the Firefox, but it probably make sense to test in various environments to ensure they don't appear there as well ex. in Edge.
- Ensure that issue reporter doesn't stuck and no error is thrown(UI#213).
- Ensure that popup closes when making the actions specified below(UI#215):
- When clicking on "Report issue"
- When clicking on the gear icon
- When clicking on "Refresh"
- Selecting an element on the page after clicking on "Block element"
- Clicking on Promotional links next to "Interested in Adblock Plus on mobile?"
- When reporting the issue ensure that the data in the dialog when clicking "Click this link to review the report data before sending" is shown structured rather than on one line(UI#214).
Attachments (0)
Change History (23)
comment:5 Changed on 10/02/2018 at 06:06:20 PM by saroyanm
- Summary changed from Update adblockplusui dependency to TBD to Update adblockplusui dependency to TBD (release-2018-4.3)
comment:7 Changed on 10/02/2018 at 06:09:34 PM by saroyanm
- Blocked By 7013 added
comment:10 Changed on 10/02/2018 at 06:19:02 PM by saroyanm
- Cc wspee sebastian kzar agiammarchi greiner added
comment:11 Changed on 10/02/2018 at 06:25:22 PM by sebastian
- Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox
- Priority changed from Unknown to P2
- Ready set
comment:12 Changed on 10/02/2018 at 06:50:10 PM by saroyanm
- Component changed from Unknown to Platform
Update the module, thanks Sebastian.
comment:13 Changed on 10/04/2018 at 11:57:43 AM by saroyanm
- Blocked By 7017 added
comment:14 Changed on 10/05/2018 at 10:01:37 AM by saroyanm
- Blocked By 7018 added
comment:15 Changed on 10/05/2018 at 10:02:21 AM by saroyanm
- Description modified (diff)
comment:16 Changed on 10/05/2018 at 10:12:01 AM by saroyanm
- Description modified (diff)
comment:17 Changed on 10/05/2018 at 10:15:47 AM by saroyanm
- Description modified (diff)
comment:18 Changed on 10/05/2018 at 10:19:59 AM by saroyanm
- Description modified (diff)
comment:19 Changed on 10/05/2018 at 11:52:48 AM by saroyanm
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to TBD (release-2018-4.3) to Update adblockplusui dependency to hg:42849c775697 (release-2018-4.3)
comment:20 Changed on 10/05/2018 at 12:01:23 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:21 Changed on 10/05/2018 at 12:13:13 PM by abpbot
A commit referencing this issue has landed:
Issue 7014 - Update adblockplusui dependency to hg:42849c775697
comment:22 Changed on 10/05/2018 at 12:15:26 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:23 Changed on 10/24/2018 at 09:15:54 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Issues listed above are fixed. Issue reporter works as expected. Popup closes as expected. FRP does not look to be missing any strings.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
@Sebastian, @kzar - there were some regressions noticed on the Firefox, 1 is fixed another one is about to fix, just a detail comment, also there are some missing translation we would like to include in ABP v3.4, please let us know if you think it's feasible to squeeze this changes into the ABP v3.4 release. Thanks in advance.