Opened on 10/03/2018 at 03:45:41 PM

Closed on 10/04/2018 at 01:22:34 PM

Last modified on 10/24/2018 at 09:07:17 AM

#7017 closed change (fixed)

Firefox popup not closing on tabs update

Reported by: agiammarchi Assignee:
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7014 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/144

Description (last modified by saroyanm)

Background

See -> https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/214

What to change

Force close the popup when starting the issue reporter

Attachments (0)

Change History (9)

comment:1 Changed on 10/03/2018 at 03:47:29 PM by agiammarchi

  • Review URL(s) modified (diff)

comment:2 Changed on 10/04/2018 at 11:56:54 AM by saroyanm

  • Description modified (diff)
  • Ready set
  • Type changed from defect to change

Changed the description to have 1 source for updating the background if needed.

comment:3 Changed on 10/04/2018 at 11:57:43 AM by saroyanm

  • Blocking 7014 added

Added blocking for dep. update ticket.

comment:4 Changed on 10/04/2018 at 11:57:53 AM by saroyanm

  • Priority changed from Unknown to P2

comment:5 Changed on 10/04/2018 at 01:21:27 PM by saroyanm

This ticket is fixed

comment:6 Changed on 10/04/2018 at 01:22:34 PM by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed on 10/04/2018 at 01:23:10 PM by agiammarchi

comment:8 Changed on 10/05/2018 at 11:44:13 AM by abpbot

A commit referencing this issue has landed:
Issue 7017 - Firefox popup not closing on tabs update

comment:9 Changed on 10/24/2018 at 09:07:17 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Popup UI closes when opening issue reporter in all browsers.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.