Opened on 10/30/2018 at 11:59:54 PM
Closed on 10/31/2018 at 06:32:38 PM
#7083 closed defect (fixed)
Release automation fails due to translations being moved to adblockplusui
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | tlucas, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
How to reproduce / Observed behaviour
When I ran ./build.py release -t chrome -t gecko -k ~/adblockpluschrome.pem 3.4 it failed with an exception reporting that there is no _locales directory in adblockpluschrome anymore.
This happens because it needs to get the product name from the translations file in order to insert it into the automatically generated commit messages.
Expected behaviour
The product name should be picked up from adblockplusui/locale/en-US/manifest.json instead. the build.py release command should succeed.
Attachments (0)
Change History (3)
comment:1 Changed on 10/31/2018 at 12:01:12 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/31/2018 at 06:27:43 PM by abpbot
comment:3 Changed on 10/31/2018 at 06:32:38 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7083 - Adapt release automation for locales being located in adblockplusui