Add no-use-before-define rule to our eslint config

[erikvold]

I'm not sure why we are not using the no-use-before-define in our eslint config.

​https://eslint.org/docs/rules/no-use-before-define

[sebastian]

Will circular dependencies still work with that rule?

function foo()
{
  if (...)
    bar();
}

function bar()
{
  if (...)
    foo();
}

[erikvold]

Replying to sebastian:

Will circular dependencies still work with that rule?

function foo()
{
  if (...)
    bar();

I'm pretty sure this line would break the rule.

We'd just have to add an exception for this pattern when we want to use it, or find an alternative implementation.

[agiammarchi]

my 2 cents: I think in UI we are very aware of how functions hoisting work so, as long as { "functions": false } is used, I personally wouldn't mind having this rule in.

[sebastian]

No objections either from my end, with functions: false.