Opened on 11/02/2018 at 01:34:26 PM
Closed on 05/16/2019 at 11:20:10 AM
Last modified on 08/26/2019 at 02:27:05 PM
#7091 closed change (fixed)
Create font generation tool
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6936, #7425 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/153 |
||
Description (last modified by greiner)
Attachments (0)
Change History (14)
comment:1 Changed on 11/02/2018 at 01:38:01 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/02/2018 at 01:38:16 PM by saroyanm
- Owner set to saroyanm
comment:3 Changed on 11/23/2018 at 01:12:16 PM by greiner
- Blocking 6936 added
comment:7 Changed on 03/12/2019 at 12:47:59 PM by greiner
Should we keep this ticket open or can we close it already?
comment:9 Changed on 03/29/2019 at 01:21:46 PM by greiner
- Blocking 7425 added
comment:10 Changed on 05/16/2019 at 11:12:23 AM by greiner
Added further GitLab issues and reviews that refer to this ticket.
comment:11 Changed on 05/16/2019 at 11:20:10 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Closing this ticket because all changes have landed by now. Note that of all those changes, only this commit is relevant for #6936 and that one doesn't affect any of the UI yet.
comment:12 Changed on 05/20/2019 at 10:58:21 AM by abpbot
A commit referencing this issue has landed:
Issue 7091 - create font generation tool
comment:13 Changed on 07/19/2019 at 10:38:06 AM by ukacar
- Verified working set
comment:14 Changed on 08/26/2019 at 02:27:05 PM by abpbot
Some commits referencing this issue have landed:
- Issue 7091 - Integrate font-tools generated fonts
- Issue 7091 - Reset fonts of filter names in custom filters list table
- Issue 7091 - Add font-tools generated files to .gitignore
- Issue 7091 - Added language subscription specializations to the shared characters
- Issue 7091 - Handle font-generation promise rejections
- Issue 7091 - Use monospace for io-filter-table error message filter
- Issue 7091 - use language prefixes to generate language lists
There is still a review for the integration into the codebase, in general I don't think that it should be release blocker, but rather something that will be good to have for the release. If we notice current issue is the only blocker and/or we wish to rush the release, I think we should be safe to leave it out of current release.