Opened on 11/30/2018 at 02:30:51 PM
Closed on 12/04/2018 at 02:23:49 PM
Last modified on 02/14/2019 at 03:24:34 PM
#7150 closed change (fixed)
Adapt code to work with latest changes to Subscription.prototype.filters
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | wspee | Blocked By: | |
| Blocking: | #7054 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/182 |
||
Description (last modified by greiner)
Background
See ui#260
What to change
See ui#260
Hints for testers
- Filter lists in desktop and mobile options page should be shown.
- Custom filters in desktop options page should be shown.
- Adding/removing custom filters should work as expected.
- Anti-adblock notification should only show up when visiting a site that matches one of its URL filters.
Attachments (0)
Change History (6)
comment:1 Changed on 11/30/2018 at 02:34:36 PM by greiner
- Owner set to greiner
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/30/2018 at 05:45:23 PM by greiner
comment:4 Changed on 12/04/2018 at 02:23:49 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/04/2018 at 02:36:03 PM by abpbot
A commit referencing this issue has landed:
Issue 7150 - Adapted code to work with latest changes to Subscription.prototype.filters
comment:6 Changed on 02/14/2019 at 03:24:34 PM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
Added hints for testers.