Opened on 01/08/2019 at 05:47:20 PM

Closed on 01/28/2019 at 05:28:16 PM

Last modified on 04/18/2019 at 10:35:31 AM

#7200 closed change (fixed)

Adjust UI colors

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.5.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29986555/

Description (last modified by diegocarloslima)

Background

There are some regressions related to the UI colors, like some white on white parts (See: Screenshot1 Screenshot2).

What to change

We should fix those color inconsistencies. We also should aim to reduce the amount of assets/color/theme changes in order to avoid more regressions like this in the future

Attachments (2)

ss1.jpg (49.3 KB) - added by diegocarloslima on 01/08/2019 at 05:47:38 PM.
ss2.jpg (56.6 KB) - added by diegocarloslima on 01/08/2019 at 05:47:46 PM.

Download all attachments as: .zip

Change History (8)

Changed on 01/08/2019 at 05:47:38 PM by diegocarloslima

Changed on 01/08/2019 at 05:47:46 PM by diegocarloslima

comment:1 Changed on 01/08/2019 at 05:50:03 PM by diegocarloslima

  • Description modified (diff)

comment:2 Changed on 01/14/2019 at 10:38:14 PM by diegocarloslima

  • Priority changed from P4 to P3

comment:3 Changed on 01/21/2019 at 07:47:31 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 01/28/2019 at 05:26:58 PM by abpbot

A commit referencing this issue has landed:
Issue 7200 - Adjust UI colors

comment:5 Changed on 01/28/2019 at 05:28:16 PM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 04/18/2019 at 10:35:31 AM by aboegler

QA LGTM

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
 
Note: See TracTickets for help on using tickets.