Opened on 01/23/2019 at 02:41:07 AM
Closed on 01/23/2019 at 04:32:20 AM
Last modified on 03/12/2019 at 06:20:50 AM
#7232 closed change (fixed)
Move function for checking if a request is third-party into adblockpluscore
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
In #7121 we moved the public suffix list into adblockpluscore. Now the isThirdParty function in lib/url.js in adblockpluschrome, which is one of the top hot spots, can also be moved into adblockpluscore.
What to change
Copy the isThirdParty function and related code from lib/url.js in adblockpluschrome to lib/domain.js in adblockpluscore.
Copy related tests from qunit/tests/url.js in adblockpluschrome into test/domain.jsin adblockpluscore.
Hints for testers
This new version of this function is not called from the extension yet, but please look for hints in the dependency update ticket.
Attachments (0)
Change History (7)
comment:1 Changed on 01/23/2019 at 02:41:36 AM by mjethani
- Owner set to mjethani
comment:2 Changed on 01/23/2019 at 03:26:55 AM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 01/23/2019 at 04:30:55 AM by abpbot
comment:5 Changed on 01/23/2019 at 04:32:20 AM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 02/07/2019 at 03:24:07 AM by abpbot
A commit referencing this issue has landed:
Issue 7232 - Move third-party request check into adblockpluscore
comment:7 Changed on 03/12/2019 at 06:20:50 AM by rscott
- Verified working set
A commit referencing this issue has landed:
Issue 7232 - Move third-party request check into adblockpluscore