Opened on 06/27/2014 at 04:09:21 PM
Last modified on 04/25/2015 at 05:16:46 PM
#724 new defect
Radio boxes in Android settings menu are not veritcally aligned
| Reported by: | philll | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Android | Keywords: | android_devbuild_1.3 goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Taken from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ABP-13
Environment
LG + LG P-895 + Android Version - 4.0.4
ABP 1.2.1.327, Build 327
How to reproduce
- Open the settings menu
Observed behaviour
The radio buttons for the fields "Acceptable Ads" and "Hide Button" are not vertically aligned properly.
Expected behaviour
The radio buttons for the fields "Acceptable Ads" and "Hide Button" should be aligned properly.
Attachments (6)
Change History (13)
comment:1 Changed on 07/24/2014 at 07:40:14 AM by fhd
- Keywords goodfirstbug added
- Platform set to Android
comment:2 Changed on 12/31/2014 at 03:24:22 PM by Mailkov
comment:3 Changed on 01/15/2015 at 06:49:40 PM by Mailkov
Hi , I would like to work on this defect
comment:4 Changed on 02/15/2015 at 07:48:11 PM by agnieszka.domanska
Hi, I would like to work on this. Good as first bug.
comment:5 Changed on 03/14/2015 at 08:45:15 PM by agnieszka.domanska
Hi. I think I solved the problem. I attached changed or added files. These are:
res/layout/helpfulcheckbox_layout.xml
res/layout/hideicon_layout.xml
res/xml/preferences.xml
src/org/adblockplus/android/HelpfulCheckBoxPreference.java
res/values-pl/strings.xml (here I just fixed a little typo)
helpfulcheckbox_layout.2.xml file is not needed. I don't know how to remove it.
Changed on 03/14/2015 at 08:46:11 PM by agnieszka.domanska
Changed on 03/14/2015 at 08:48:44 PM by agnieszka.domanska
layouts to helpfulCheckboxPreference i 'Hide Icon' checkboxPreference added
Changed on 03/14/2015 at 08:49:59 PM by agnieszka.domanska
typo fixed
Changed on 03/15/2015 at 11:40:09 AM by agnieszka.domanska
Changed on 03/15/2015 at 11:40:24 AM by agnieszka.domanska
new custom layout for helpfulCheckboxPreference
Changed on 03/15/2015 at 11:40:34 AM by agnieszka.domanska
new custom layout for 'Hide Icon' checkboxPreference - unnecessary to align it with helpfulCheckboxPreference
comment:6 Changed on 03/15/2015 at 11:42:44 AM by agnieszka.domanska
comment:7 Changed on 04/25/2015 at 05:16:46 PM by agnieszka.domanska
Pull request with a fix sent on github.
Hi , I would like to work on this bug.