Remove ability to pass callback function into wrapped browser.* APIs

[kzar]

Background

Once we have ensured that no code that calls browser.* APIs passes in callbacks, we can simplify the adblockpluschrome/polyfill.js code. This will also make sure that new code doesn't start passing callbacks again.

What to change

Simplify the API wrapping code so that passing in a callback function is no longer supported.

In polyfill.js:

  function wrapAsyncAPI(api)
  {
    ...

        if (typeof args[args.length - 1] == "function")
          return func.apply(object, args);

        // If the last argument is undefined, we drop it from the list assuming
        // it stands for the optional callback. We must do this, because we have
        // to replace it with our own callback. If we simply append our own
        // callback to the list, it won't match the signature of the function
        // and will cause an exception.
        if (typeof args[args.length - 1] == "undefined")
          args.pop();

    ...

Remove this part of the code.

Hints for testers

Run some basic smoke tests, e.g. open the options page, add/remove subscriptions, update filter lists manually, change some preferences, browse to some web pages, and make sure there are no errors in the background page console and the options page console.

[mjethani]

Just to share my two cents here:

  function wrapAsyncAPI(api)
  {
    ...

        if (typeof args[args.length - 1] == "function")
          return func.apply(object, args);

        // If the last argument is undefined, we drop it from the list assuming
        // it stands for the optional callback. We must do this, because we have
        // to replace it with our own callback. If we simply append our own
        // callback to the list, it won't match the signature of the function
        // and will cause an exception.
        if (typeof args[args.length - 1] == "undefined")
          args.pop();

    ...

In both the function and undefined cases, now we should throw an error. If any errors appear in the console we know we need to fix that part.

[kzar]

Sounds good to me. Feel free to flesh out the issue description, sounds like you have a good idea how it should work.

[mjethani]

I have uploaded a ​patch but first the issues that this depends on need to be addressed.

[kzar]

Nice one, thanks. I'll take a look once the other stuff's sorted.

[abpbot]

A commit referencing this issue has landed:
​Issue 7334 - Remove support for callbacks in API wrappers

[abpbot]

Removed. This message was posted because of a mistake in the commit message.

[Ross]

Done. Doesn't look to have caused any regressions.

ABP 0.9.15.2339
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2339
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2