Opened on 02/11/2019 at 12:28:37 PM
Closed on 03/08/2019 at 02:50:57 PM
Last modified on 06/10/2019 at 01:35:11 PM
#7272 closed change (fixed)
Use promises for extension API calls in UI
| Reported by: | greiner | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | manifestv3 |
| Cc: | Blocked By: | ||
| Blocking: | #7334, #7343 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/242 |
||
Description (last modified by greiner)
Background
See ui#323
What to change
See ui#323
Hints for testers
This change affects large parts of the functionality in the following UIs:
- Bubble UI
- Desktop options page
- DevTools panel
- Issue reporter
- Mobile options page
In particular when it comes to:
- Accessing extension data (settings, filters, filter lists etc.) and other browser data (e.g. screenshot in issue reporter)
- Changing extension data and showing errors, if necessary
- Reacting to changes in extension data
- Initializing external links
Apart from those, the lang and dir attributes should be correctly set on the <html> element of a UI to reflect the UI locale and text direction.
Attachments (0)
Change History (11)
comment:1 Changed on 02/11/2019 at 12:30:44 PM by greiner
- Keywords manifestv3 added
comment:2 Changed on 02/11/2019 at 12:31:32 PM by greiner
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 03/06/2019 at 08:30:51 AM by kzar
- Blocking 7334 added
comment:4 Changed on 03/07/2019 at 05:45:13 PM by hfiguiere
- Owner set to hfiguiere
comment:5 Changed on 03/07/2019 at 09:28:00 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 03/07/2019 at 10:24:29 PM by greiner
- Blocking 7343 added
comment:8 Changed on 03/08/2019 at 10:32:14 AM by greiner
comment:9 Changed on 03/08/2019 at 02:50:57 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 03/18/2019 at 12:55:48 PM by abpbot
A commit referencing this issue has landed:
Issue 7272 - Use the extension Promise API
comment:11 Changed on 06/10/2019 at 01:35:11 PM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
Added hints for testers.
@hfiguiere Please check and add to/correct it, if necessary.