Opened on 03/07/2019 at 06:13:07 PM
Closed on 04/25/2019 at 08:50:23 AM
Last modified on 07/21/2019 at 09:04:43 PM
#7342 closed change (fixed)
Remove the code handling the data migration from ioIndexedDB
| Reported by: | geo | Assignee: | geo |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Chrome-Opera-Firefox-next |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/47 |
||
Description (last modified by sebastian)
Background
With 6621 we started using IndexedDB directly and added a migration path from localforage (used in 0.9.11 and before). With 6775 we implemented a backup strategy in order to deal with the volatile properties of IndexedDB, which added further complexity to the migration path.
By the time 0.9.15 will be releases we assume that the vast majority of users are no longer on a version that uses localForage (i.e. <=0.9.11), so that we can simplify the code path by removing the migration logic, which in turn might also make data storage more reliable as some users are still reporting data corruptions.
What to change
Remove the code handling the migration from localForage in ioIndexedDB.
Attachments (0)
Change History (6)
comment:1 Changed on 03/07/2019 at 11:00:09 PM by sebastian
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 03/14/2019 at 02:02:51 PM by geo
- Owner set to geo
comment:4 Changed on 04/02/2019 at 06:34:17 PM by abpbot
comment:5 Changed on 04/25/2019 at 08:50:23 AM by geo
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 07/21/2019 at 09:04:43 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as described. Storage works as expected.
ABP 3.5.2.2339
Microsoft Edge 44.17763.1.0
A commit referencing this issue has landed:
Issue 7342 - Remove the code handling the data migration from ioIndexedDB