Opened on 03/07/2019 at 10:23:28 PM
Closed on 03/18/2019 at 02:50:04 PM
Last modified on 06/10/2019 at 01:35:36 PM
#7343 closed change (fixed)
Update adblockplusui dependency to f24c0b314ac8 (release-2018-5.-5)
| Reported by: | greiner | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Chrome-Opera-Firefox-next |
| Module: | Platform | Keywords: | |
| Cc: | snoack, hfiguiere, kzar | Blocked By: | #7272, #7365, #7366 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/48 |
||
Description (last modified by kzar)
Background
This dependency update ensures that none of the currently used UI code passes callbacks anymore when calling extension APIs.
This imports the following changes:
| Ticket | Status | Resolution | Summary | Component | Owner |
|---|---|---|---|---|---|
| #7272 | closed | fixed | Use promises for extension API calls in UI | User-Interface | hfiguiere |
| #7365 | closed | fixed | Blank screenshot in issue reporter | User-Interface | greiner |
What to change
Change adblockplusui dependency to hg:f24c0b314ac8 git:22c1ea9
Integration notes
browser.tabs.captureVisibleTab needs to be added to the list in polyfill.js so that it returns a promise (see #7366).
Hints for testers
- Ensure the issue reporter includes a screenshot on Firefox, see this GitLab issue.
- Test a bunch of stuff listed in the testing hints for issue 7272.
Attachments (0)
Change History (15)
comment:1 Changed on 03/07/2019 at 10:24:29 PM by greiner
- Blocked By 7272 added
comment:2 Changed on 03/07/2019 at 10:28:08 PM by greiner
- Cc snoack hfiguiere added
- Description modified (diff)
comment:3 Changed on 03/08/2019 at 10:48:37 AM by greiner
- Summary changed from Update adblockplusui dependency to TBD (release-2019-1.-9) to Update adblockplusui dependency to TBD (release-2018-5.-5)
comment:4 Changed on 03/14/2019 at 01:57:01 PM by greiner
- Blocked By 7365 added
comment:5 Changed on 03/14/2019 at 01:57:10 PM by greiner
- Blocked By 7366 added
comment:6 Changed on 03/14/2019 at 02:14:33 PM by greiner
- Description modified (diff)
Added integration notes.
comment:7 Changed on 03/18/2019 at 12:57:29 PM by greiner
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to TBD (release-2018-5.-5) to Update adblockplusui dependency to f24c0b314ac8 (release-2018-5.-5)
Added hashes to ticket description.
comment:8 Changed on 03/18/2019 at 02:14:53 PM by kzar
- Cc kzar added
- Description modified (diff)
- Priority changed from Unknown to P2
Issue looks good, except I don't see the change for #7366 included in this dependency update. Was that omitted deliberately?
comment:9 Changed on 03/18/2019 at 02:20:45 PM by kzar
- Description modified (diff)
- Owner set to kzar
- Ready set
comment:10 Changed on 03/18/2019 at 02:28:43 PM by kzar
- Review URL(s) modified (diff)
comment:11 Changed on 03/18/2019 at 02:28:56 PM by kzar
- Status changed from new to reviewing
comment:12 Changed on 03/18/2019 at 02:49:19 PM by abpbot
A commit referencing this issue has landed:
Issue 7343 - Update adblockplusui dependency to f24c0b314ac8
comment:13 Changed on 03/18/2019 at 02:50:04 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:14 Changed on 03/19/2019 at 12:46:37 PM by greiner
Just for the record: #7366 is not part of this dependency update because it only affects the UI fork of adblockpluschrome which is used to build the UI Nightlies. Instead, the change was taken care of as mentioned in the integration notes.
comment:15 Changed on 06/10/2019 at 01:35:36 PM by ukacar
- Verified working set
Renamed release to indicate that it's going to land before #6936.