Notification animations error on Edge

[Ross]

Environment

ABP 0.9.13.2261
Edge 44.17763.1.0 / Windows 10

NOT a regression compared to 0.9.13 Edge release.

How to reproduce

1. Serve notification file below.
2. Install ABP.
3. Inspect the ABP popup, in the console run:

browser.runtime.sendMessage({type: "prefs.set", key: "notificationurl", value: "http://urlto.the/notification.json"})

4. Wait 60s until you see notification has been requested.

Test notification

{
  "notifications": [
    {
      "id": "information_onelink",
      "severity": "information",
      "links": [
        "adblock_browser_promotion_0"
      ],
      "title": {
        "en-US": "Test Information Notification",
        "de": "DE Test Information Notification"
      },
      "message": {
        "en-US": "This is a <a>test</a> information notification.",
        "de": "DE This is a <a>test</a> information notification."
      }
    }
  ],
  "version": "201810011538"
}

Observed behaviour

The follow error appears in the console, while attempting to animate the notification:

SCRIPT5022: SCRIPT5022: Error: Invalid value for argument 1. Property 'imageData': Unexpected property, Property 'path': Property is required.
adblockplus.js (11092,13)

3360: Error: Invalid value for argument 1. Property 'imageData': Unexpected property, Property 'path': Property is required.

Expected behaviour

The error not to be logged to the console and icon animations to work as expected. The information notification should animate a ?, the critical notification should animate a !.

Hints for testers

Due to API limitations, we can't have the same nice animation as with the other browsers, instead we just toggle between icons.

[sebastian]

Is this a duplicate of #5746?

[geo]

Edge doesn't support imageData. A workaround would be to toggle between the normal icon and the notification icon, skipping the fade effect.

Also regarding 5746 I don't think that this ticket is a duplicate, I had some issues seeing the notifications a few times, but I'm using a different setup and I think that was the problem.

[sebastian]

That makes sense. The suggested workaround sounds reasonable to me.

[kzar]

Replying to geo:

Edge doesn't support imageData.

What about the new Chromium-based Edge?

[Ross]

Replying to kzar:

Replying to geo:

Edge doesn't support imageData.

What about the new Chromium-based Edge?

The icon animations work as expected (just like Chrome) as far as I can tell in 76.0.159.0 / Edge Chromium.

[abpbot]

A commit referencing this issue has landed:
​Issue 7347 - Stopped using imageData for displaying notifications on Edge

[Ross]

Fixed. Notification animations work on all platforms.

ABP 0.9.15.2339
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2339
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809

[booms1]

spam