Opened on 03/25/2019 at 05:12:40 PM
Closed on 04/11/2019 at 05:21:58 PM
Last modified on 10/08/2019 at 06:07:51 PM
#7401 closed change (fixed)
Adapt code to work with removed Subscription.prototype.filters
| Reported by: | greiner | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | jsonesen | Blocked By: | |
| Blocking: | #7308 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/249 |
||
Attachments (0)
Change History (9)
comment:1 Changed on 04/10/2019 at 12:26:53 AM by jsonesen
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/10/2019 at 10:18:48 AM by greiner
- Owner set to jsonesen
comment:3 Changed on 04/11/2019 at 05:21:58 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 04/11/2019 at 11:41:55 PM by jsonesen
Will a trac issue for the next release be made as well so we can block the 7308 ticket, since it is still not ready
comment:5 Changed on 04/12/2019 at 12:46:25 PM by greiner
comment:6 Changed on 04/17/2019 at 12:29:36 PM by greiner
- Review URL(s) modified (diff)
Added another change that makes sure this change also works with our UI Nightlies so that we can test it.
comment:7 Changed on 04/26/2019 at 12:48:43 PM by abpbot
A commit referencing this issue has landed:
Issue 7401 - Adapt filter objects to text per changes to Subscription.prototype.filterText
comment:8 Changed on 04/29/2019 at 08:57:15 AM by yoyo888
spam
Last edited on 10/08/2019 at 06:07:51 PM
by kzar
comment:9 Changed on 07/26/2019 at 11:41:06 AM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
Done: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/e86b9848b6c882497662a62892130e3a4cd37f5b