Opened on 03/25/2019 at 01:31:34 PM
Closed on 03/31/2019 at 10:07:59 AM
Last modified on 07/25/2019 at 10:06:44 PM
#7400 closed defect (fixed)
:-abp-properties() does not work when tag name is specified
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | amr, agiammarchi, hfiguiere | Blocked By: | |
| Blocking: | #7359 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/38 |
||
Description (last modified by mjethani)
Environment
Adblock Plus 3.5
Google Chrome 75 (Canary)
macOS 10.12
How to reproduce
Add the filter #?#span:-abp-properties(color: red)
Then load the following document:
<html>
<head>
<style>
span {
color: red;
}
</style>
</head>
<body>
<span>Ad</span>
</body>
</html>
Observed behaviour
The text "Ad" is not hidden.
Expected behaviour
The text "Ad" should be hidden.
Notes
It seems qualifySelector() qualifies span with prefix span as spanspan. If the filter is changed to simply #?#:-abp-properties(color: red), it works.
This might be is related to #7359.
Hints for testers
Also test the case in #7359.
Attachments (0)
Change History (11)
comment:1 Changed on 03/25/2019 at 01:32:33 PM by mjethani
- Component changed from Unknown to Core
- Priority changed from Unknown to P2
- Ready set
comment:4 Changed on 03/25/2019 at 03:06:44 PM by mjethani
- Owner set to mjethani
comment:5 Changed on 03/25/2019 at 04:59:10 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 03/28/2019 at 08:40:40 PM by hfiguiere
- Blocked By 7359 added
comment:7 Changed on 03/28/2019 at 08:40:51 PM by hfiguiere
- Blocked By 7359 removed
- Blocking 7359 added
comment:8 Changed on 03/31/2019 at 10:05:45 AM by abpbot
A commit referencing this issue has landed:
Issue 7400 - Handle identical types in qualifySelector()
comment:9 Changed on 03/31/2019 at 10:07:59 AM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 04/02/2019 at 07:03:50 AM by mjethani
- Description modified (diff)
comment:11 Changed on 07/25/2019 at 10:06:44 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as described.
ABP 0.9.15.2339
Microsoft Edge 44.17763.1.0 / Windows 10 1809
ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2
I believe this issue #7359.