Opened on 03/31/2019 at 10:01:33 AM

Closed on 04/01/2019 at 03:00:57 PM

Last modified on 07/25/2019 at 10:19:03 PM

#7428 closed defect (fixed)

:-abp-properties() does not work when selector in document ends in a combinator

Reported by:	mjethani	Assignee:	mjethani
Priority:	P2	Milestone:
Module:	Core	Keywords:
Cc:	amr, agiammarchi, hfiguiere	Blocked By:
Blocking:	#7359	Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Ross	Verified working:	yes
Review URL(s):	https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/43 https://codereview.adblockplus.org/30035555/

Description (last modified by mjethani)

Environment

Adblock Plus 3.5
Google Chrome 75 (Canary)
macOS 10.12

How to reproduce

Add the filter #?#body :-abp-properties(color: red)

Then load the following document:

<html>
  <head>  
    <style>   
      span.ad {   
        color: red;
      }        
    </style>
  </head>      
  <body>    
    <span class="ad">Ad</span>
  </body> 
</html>

Observed behaviour

The text "Ad" is not hidden.

Expected behaviour

The text "Ad" should be hidden.

Hints for testers

Also test the case in #7359.

Change History (14)

comment:1 Changed on 03/31/2019 at 10:01:43 AM by mjethani

Summary changed from :-abp-properties() does not work when selector in documents ends in a combinator to :-abp-properties() does not work when selector in document ends in a combinator

comment:2 Changed on 03/31/2019 at 10:02:16 AM by mjethani

Description modified (diff)

comment:3 Changed on 03/31/2019 at 10:03:24 AM by mjethani

Ready set

comment:4 Changed on 03/31/2019 at 10:08:26 AM by mjethani

Cc amr agiammarchi hfiguiere added

comment:5 Changed on 03/31/2019 at 10:41:13 AM by mjethani

Description modified (diff)

comment:6 Changed on 03/31/2019 at 10:46:57 AM by mjethani

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:7 Changed on 04/01/2019 at 01:52:07 PM by hfiguiere

As a side effect the patch for this also fixes issue #7359

comment:8 Changed on 04/01/2019 at 02:59:10 PM by abpbot

A commit referencing this issue has landed:
Issue 7428 - Handle qualifiers ending in combinators

comment:9 Changed on 04/01/2019 at 03:00:57 PM by mjethani

Resolution set to fixed
Status changed from reviewing to closed

comment:10 Changed on 04/01/2019 at 05:37:18 PM by hfiguiere

Blocking 7359 added

comment:11 Changed on 04/02/2019 at 07:04:03 AM by mjethani

Description modified (diff)

comment:12 Changed on 04/02/2019 at 02:31:50 PM by hfiguiere

Review URL(s) modified (diff)

Added tests for issue 7359 test case.

comment:13 Changed on 04/03/2019 at 08:46:10 PM by abpbot

A commit referencing this issue has landed:
Issue 7428, 7400 - Add test case for nested :-abp-properties()

comment:14 Changed on 07/25/2019 at 10:19:03 PM by Ross

Tester changed from Unknown to Ross
Verified working set

Done. Working as described.

ABP 0.9.15.2339
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2

Context Navigation