Opened on 03/13/2019 at 04:10:54 PM
Closed on 04/02/2019 at 07:00:46 AM
#7359 closed defect (duplicate)
:-abp-has() does not work with nested :-abp-properties() where the :-abp-properties() selector ends in a combinator
| Reported by: | agiammarchi | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | amr, hfiguiere, mjethani | Blocked By: | #7400, #7428 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mjethani)
Environment
Adblock Plus 3.5
Unknown browser
Unknown OS
How to reproduce
Add the following filter:
#?#div:-abp-has(> a p > span:-abp-properties(content: "any"))
Load the following document in the browser:
<!DOCTYPE html>
<html>
<head>
<style>
span::before {
content: "any";
}
</style>
</head>
<body>
<div>
<a>
<p>
<span></span>
</p>
</a>
</div>
</body>
</html>
Observed behavior
The content is not hidden.
Expected behavior
The content is hidden.
Notes
This is a manifestation of #7428.
The original report said that the filter #?#div:-abp-has(> a p:-abp-has(> span:-abp-properties(content: "any"))) also did not work (#7400).
Resolution
Both #7400 and #7428 have been fixed, as a result this is now a duplicate issue.
Attachments (0)
Change History (19)
comment:1 Changed on 03/13/2019 at 04:14:12 PM by amrmak
- Cc amr added
comment:2 Changed on 03/13/2019 at 05:13:05 PM by mjethani
- Cc hfiguiere mjethani added
comment:3 Changed on 03/18/2019 at 01:44:04 PM by hfiguiere
- Summary changed from -apb-has shouldn't need nested -abp-has to -abp-has shouldn't need nested -abp-has
comment:6 Changed on 03/22/2019 at 06:58:01 PM by hfiguiere
qualifySelector() returns something incorrect.
comment:7 Changed on 03/25/2019 at 12:46:47 PM by mjethani
- Description modified (diff)
- Summary changed from -abp-has shouldn't need nested -abp-has to :-abp-has() shouldn't need nested :-abp-has()
comment:10 Changed on 03/25/2019 at 01:24:49 PM by mjethani
Neither of the filters work for me. The problem appears not to be nesting but rather something else.
comment:11 Changed on 03/25/2019 at 01:26:05 PM by mjethani
- Description modified (diff)
comment:12 Changed on 03/25/2019 at 01:35:17 PM by mjethani
- Description modified (diff)
I have filed #7400 for a more specific issue.
Can somebody confirm that the second filter also does not work? I don't think the nesting is really the problem here, but I may be wrong.
comment:13 Changed on 03/25/2019 at 01:48:43 PM by hfiguiere
I don't get the second filter to work either.
comment:14 Changed on 03/25/2019 at 01:50:39 PM by mjethani
OK, let's address #7400 and it might fix this issue as well.
comment:15 Changed on 03/28/2019 at 08:40:40 PM by hfiguiere
- Blocking 7400 added
comment:16 Changed on 03/28/2019 at 08:40:51 PM by hfiguiere
- Blocked By 7400 added
- Blocking 7400 removed
comment:17 Changed on 04/01/2019 at 05:37:18 PM by hfiguiere
- Blocked By 7428 added
This is fixed by issue #7428. I will add some regression tests to ensure this issue doesn't come back.
comment:18 Changed on 04/01/2019 at 08:47:42 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:19 Changed on 04/02/2019 at 07:00:46 AM by mjethani
- Description modified (diff)
- Resolution set to duplicate
- Status changed from reviewing to closed
- Summary changed from :-abp-has() shouldn't need nested :-abp-has() to :-abp-has() does not work with nested :-abp-properties() where the :-abp-properties() selector ends in a combinator
I'm assuming you are saying that the second filter doesn't work.