Opened on 03/11/2014 at 09:24:59 AM

Closed on 03/13/2014 at 12:04:06 AM

Last modified on 10/08/2019 at 06:08:39 PM

#8 closed change (fixed)

[libadblockplus integration cleanup] Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild

Reported by: fhd Assignee: fhd
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #7 Platform:
Ready: Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

See #7

What to change

Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild. (​http://codereview.adblockplus.org/11172036/diff/1/jni/abpEngine.cpp#newcode154)

Attachments (0)

Change History (12)

comment:1 Changed on 03/11/2014 at 09:46:57 AM by philll

  • Summary changed from Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild to [libadblockplus integration cleanup] Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild

comment:2 Changed on 03/11/2014 at 12:57:59 PM by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed on 03/11/2014 at 09:34:51 PM by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed on 03/12/2014 at 11:38:19 AM by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed on 03/12/2014 at 04:42:03 PM by fhd

  • Reporter changed from philll to fhd

comment:6 Changed on 03/12/2014 at 04:55:19 PM by fhd

  • Priority changed from Unknown to P3

comment:7 Changed on 03/12/2014 at 05:12:33 PM by fhd

  • Owner rjeschke deleted

comment:8 Changed on 03/12/2014 at 05:12:56 PM by fhd

  • Status changed from assigned to accepted

comment:9 Changed on 03/13/2014 at 12:04:01 AM by fhd

  • Owner set to fhd
  • Status changed from accepted to assigned

comment:10 Changed on 03/13/2014 at 12:04:06 AM by fhd

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:11 Changed on 04/13/2014 at 06:33:25 PM by trev

  • Milestone set to Adblock-Plus-for-Android-next

comment:12 Changed on 06/19/2018 at 05:40:23 AM by johnson83

spam

Last edited on 10/08/2019 at 06:08:39 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.