Opened on 07/16/2014 at 08:58:54 AM

Closed on 07/23/2014 at 07:02:09 AM

Last modified on 07/31/2014 at 08:37:32 AM

#1032 closed change (fixed)

Use the referrer mapping API from libadblockplus

Reported by: fhd Assignee:
Priority: P2 Milestone: Adblock-Plus-1.2-for-Internet-Explorer
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #984
Blocking: #120 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6321034575740928/

Description

Background

With #984, libadblockplus will get an API for building a chain of referrers for specific URLs. This is necessary for domain-based whitelisting to work within nested frames on platforms where we don't have any way to figure out the real frame structure.

What to change

Call ReferrerMapping::Add for each request and pass the result of ReferrerMapping::BuildReferrerChain to the respective FilterEngine::Matches call.

Attachments (0)

Change History (4)

comment:1 Changed on 07/16/2014 at 09:07:22 AM by fhd

  • Blocking 120 added

comment:2 Changed on 07/22/2014 at 10:05:03 AM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/23/2014 at 07:02:09 AM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 07/31/2014 at 08:37:32 AM by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.